Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3p embeds in Firefox #960

Merged
merged 1 commit into from
Nov 18, 2015
Merged

Fix 3p embeds in Firefox #960

merged 1 commit into from
Nov 18, 2015

Conversation

cramforce
Copy link
Member

Fixes Firefox-only (or at least limited to some browsers) bug where data passed via fragment was encoded and thus failed JSON parsing.

Fixes #959

@cramforce
Fixes Firefox-only (or at least limited to some browsers) bug where
731affd 
data passed via fragment was encoded and thus failed JSON parsing.

Fixes ampproject#959
@dvoytenko
Copy link
Contributor

LGTM

cramforce added a commit that referenced this pull request Nov 18, 2015
@cramforce
Merge pull request #960 from cramforce/fx-json-fragment
affbd3c 
Fix 3p embeds in Firefox
@cramforce cramforce merged commit affbd3c into ampproject:master Nov 18, 2015
@cramforce cramforce deleted the fx-json-fragment branch November 18, 2015 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dvoytenko dvoytenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cramforce @dvoytenko